> - if (xfs_attr_log_item_op(attrp) == XFS_ATTRI_OP_FLAGS_PPTR_REPLACE) { > + switch (xfs_attr_log_item_op(attrp)) { > + case XFS_ATTRI_OP_FLAGS_PPTR_REPLACE: > ASSERT(attr->xattri_nameval->value.i_len == > attr->xattri_nameval->new_value.i_len); > > + attrp->alfi_igen = VFS_I(attr->xattri_da_args->dp)->i_generation; Please avoid the overly long lines (maybe xattri_da_args needs a shortet name or we want a local variable for it?)