On Tue, Apr 09, 2024 at 05:51:41PM -0700, Darrick J. Wong wrote: > +#define XFS_ATTR_ONDISK_MASK (XFS_ATTR_NSP_ONDISK_MASK | \ > + XFS_ATTR_LOCAL | \ > + XFS_ATTR_INCOMPLETE) Note that XFS_ATTR_LOCAL and XFS_ATTR_INCOMPLETE are not valid for short form directories. Should we check for that somewhere as well? Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>
