On Mon, Apr 08, 2024 at 04:54:48PM +0200, Christoph Hellwig wrote: > tmp_logflags is initialized to 0 and then ORed into bma->logflags, which > isn't actually doing anything. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> Looks good, Reviewed-by: Darrick J. Wong <djwong@xxxxxxxxxx> --D > --- > fs/xfs/libxfs/xfs_bmap.c | 3 --- > 1 file changed, 3 deletions(-) > > diff --git a/fs/xfs/libxfs/xfs_bmap.c b/fs/xfs/libxfs/xfs_bmap.c > index 14196d918865ba..a847159302703a 100644 > --- a/fs/xfs/libxfs/xfs_bmap.c > +++ b/fs/xfs/libxfs/xfs_bmap.c > @@ -4191,7 +4191,6 @@ xfs_bmapi_allocate( > struct xfs_mount *mp = bma->ip->i_mount; > int whichfork = xfs_bmapi_whichfork(bma->flags); > struct xfs_ifork *ifp = xfs_ifork_ptr(bma->ip, whichfork); > - int tmp_logflags = 0; > int error; > > ASSERT(bma->length > 0); > @@ -4262,8 +4261,6 @@ xfs_bmapi_allocate( > error = xfs_bmap_add_extent_hole_real(bma->tp, bma->ip, > whichfork, &bma->icur, &bma->cur, &bma->got, > &bma->logflags, bma->flags); > - > - bma->logflags |= tmp_logflags; > if (error) > return error; > > -- > 2.39.2 > >
