On Mon, Apr 08, 2024 at 04:54:52PM +0200, Christoph Hellwig wrote:
> Both callers of xfs_bmapi_allocate already initialize bma->prev, don't
> redo that in xfs_bmapi_allocate.
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
Looks ok,
Reviewed-by: Darrick J. Wong <djwong@xxxxxxxxxx>
--D
> ---
> fs/xfs/libxfs/xfs_bmap.c | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/fs/xfs/libxfs/xfs_bmap.c b/fs/xfs/libxfs/xfs_bmap.c
> index aa182937de4641..08e13ebdee1b53 100644
> --- a/fs/xfs/libxfs/xfs_bmap.c
> +++ b/fs/xfs/libxfs/xfs_bmap.c
> @@ -4196,11 +4196,6 @@ xfs_bmapi_allocate(
> ASSERT(bma->length > 0);
> ASSERT(bma->length <= XFS_MAX_BMBT_EXTLEN);
>
> - if (bma->wasdel) {
> - if (!xfs_iext_peek_prev_extent(ifp, &bma->icur, &bma->prev))
> - bma->prev.br_startoff = NULLFILEOFF;
> - }
> -
> if (bma->flags & XFS_BMAPI_CONTIG)
> bma->minlen = bma->length;
> else
> --
> 2.39.2
>
>
