On Tue, Apr 02, 2024 at 02:37:50PM +0200, Andrey Albershteyn wrote: > On 2024-03-29 17:39:11, Darrick J. Wong wrote: > > From: Darrick J. Wong <djwong@xxxxxxxxxx> > > > > xfs_inode.i_flags is an unsigned long, so make these helpers take that > > as the flags argument instead of unsigned short. This is needed for the > > next patch. > > > > Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx> > > --- > > fs/xfs/xfs_inode.h | 14 +++++++------- > > 1 file changed, 7 insertions(+), 7 deletions(-) > > > > > > Would it also make sense to flip iflags to unsigned long in > xfs_iget_cache_miss()? I think it could pass XFS_INEW directly to xfs_iflags_set and skip the iflags local variable completely. IIRC it /was/ used to set dontcache back when that was an xfs-specific flag. > Looks good to me: > Reviewed-by: Andrey Albershteyn <aalbersh@xxxxxxxxxx> Thanks! --D > -- > - Andrey > >
