On Thu, Mar 28, 2024 at 09:25:16AM +0100, Christoph Hellwig wrote: > On Thu, Mar 28, 2024 at 03:42:19PM +1100, Dave Chinner wrote: > > > Unfortunately there are different. For data device blocks we use the > > > lazy sb counters and thus never updated the sb version for any file > > > system new enough to support scrub. For RT extents lazy sb counters > > > only appear half way down Darrick's giant stack and aren't even > > > upstream yet. > > > > Can you add a comment to either the code or commit message to that > > effect? Otherwise I'm going to forget about that and not be able to > > discover it from looking at the code and/or commit messages... > > Does this look good? > > http://git.infradead.org/?p=users/hch/xfs.git;a=commitdiff;h=91bbe4c2d5518a1f991d7f19aad350d636e42d32 Spot on. Thanks! -Dave. -- Dave Chinner david@xxxxxxxxxxxxx