On Wed, Mar 27, 2024 at 12:03:15PM +0100, Christoph Hellwig wrote: > Add a check for files on the RT subvolume and use m_frextents instead > of m_fdblocks to adjust the preallocation size. > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > Reviewed-by: Darrick J. Wong <djwong@xxxxxxxxxx> One minor nit: > + if (unlikely(XFS_IS_REALTIME_INODE(ip))) > + freesp = xfs_rtx_to_rtb(mp, xfs_iomap_freesp(&mp->m_frextents, > + mp->m_low_rtexts, &shift)); It took me extra brain cells to realise that this had nested function calls because of the way the long line is split. Can we change it to look like this: freesp = xfs_rtx_to_rtb(mp, xfs_iomap_freesp(&mp->m_frextents, mp->m_low_rtexts, &shift)); Just to make it a little easier to spot the nested function and which parameters belong to which function? Regardless, the code looks correct, so: Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> -Dave. -- Dave Chinner david@xxxxxxxxxxxxx
