On Mon, Mar 25, 2024 at 10:32:37PM -0700, Christoph Hellwig wrote: > > /* no readahead, need to avoid set-but-unused var warnings. */ > > #define xfs_buf_readahead(a,d,c,ops) ({ \ > > + void *__a = a; \ > > xfs_daddr_t __d = d; \ > > + __a = __a; \ > > __d = __d; /* no set-but-unused warning */ \ > > What about turning this into an inline function instead of piling > more hacks like this onto the existing ones? Done. static inline void xfs_buf_readahead( struct xfs_buftarg *target, xfs_daddr_t blkno, size_t numblks, const struct xfs_buf_ops *ops) { } --D