Re: [PATCH 3/5] xfs_scrub: fix threadcount estimates for phase 6

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Mar 26, 2024 at 09:30:06AM -0700, Darrick J. Wong wrote:
> > Maybe add a comment to the code stating this?
> 
> 	/*
> 	 * Each read-verify pool starts a thread pool, and each worker thread
> 	 * can contribute to the progress counter.  Hence we need to set
> 	 * nr_threads appropriately to handle that many threads.
> 	 */
> 	*nr_threads = disk_heads(ctx->datadev);
> 	if (ctx->rtdev)
> 		*nr_threads += disk_heads(ctx->rtdev);
> 	if (ctx->logdev)
> 		*nr_threads += disk_heads(ctx->logdev);

Looks reaѕonable.





[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux