Re: [PATCHSET V2 05/18] xfsprogs: fix log sector size detection

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Mar 25, 2024 at 07:56:02PM -0700, Darrick J. Wong wrote:
> Hi all,
> 
> From Christoph Hellwig,
> 
> this series cleans up the libxfs toplogy code and then fixes detection
> of the log sector size in mkfs.xfs, so that it doesn't create smaller
> than possible log sectors by default on > 512 byte sector size devices.
> 
> Note that this doesn't cleanup the types of the topology members, as
> that creeps all the way into platform_findsize.  Which has a lot more
> cruft that should be dealth with and is worth it's own series.

Oops, heh, in all the rebasing confusion I forgot to update this cover
letter in my database.  This is actually the V3 patchset, though I
couldn't tell any difference between V2 and V3..

--D

> Changes since v1:
>  - fix a spelling mistake
>  - add a few more cleanups
> 
> If you're going to start using this code, I strongly recommend pulling
> from my git trees, which are linked below.
> 
> This has been running on the djcloud for months with no problems.  Enjoy!
> Comments and questions are, as always, welcome.
> 
> --D
> 
> xfsprogs git tree:
> https://git.kernel.org/cgit/linux/kernel/git/djwong/xfsprogs-dev.git/log/?h=mkfs-fix-log-sector-size
> ---
> Commits in this patchset:
>  * libxfs: remove the unused fs_topology_t typedef
>  * libxfs: refactor the fs_topology structure
>  * libxfs: remove the S_ISREG check from blkid_get_topology
>  * libxfs: also query log device topology in get_topology
>  * mkfs: use a sensible log sector size default
> ---
>  libxfs/topology.c |  109 ++++++++++++++++++++++++++---------------------------
>  libxfs/topology.h |   19 ++++++---
>  mkfs/xfs_mkfs.c   |   71 ++++++++++++++++-------------------
>  repair/sb.c       |    2 -
>  4 files changed, 100 insertions(+), 101 deletions(-)
> 
> 




[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux