On Mon, Mar 18, 2024 at 11:53:58PM -0700, Christoph Hellwig wrote: > So while this looks good to me, > > > + for (i = 0; i < bp->b_folio_count; i++) { > > + if (bp->b_folios[i]) > > + __folio_put(bp->b_folios[i]); > > The __folio_put here really needs to be folio_put or page alloc > debugging gets very unhappy. *nod* I can't remember why I used that in the first place... > But even with that fixed on top of this patch the first mount just hangs > without a useful kernel backtrace in /proc/*/stack, although running > with the entire ѕeries applied it does pass the basic sanity checking > so far. Huh. It worked before I folded in your patches to clean everything up; I don't tend to test individual patches if the whole series works. I guess I screwed something up somewhere and then fixed it later - I'll sort that out. -Dave. -- Dave Chinner david@xxxxxxxxxxxxx