On Tue, Mar 19, 11:16, Dave Chinner wrote > + /* > + * Well, that sucks. Put the inode back on the inactive queue. > + * Do this while still under the ILOCK so that we can set the > + * NEED_INACTIVE flag and clear the INACTIVATING flag an not > + * have another lookup race with us before we've finished > + * putting the inode back on the inodegc queue. > + */ > + spin_unlock(&ip->i_flags_lock); > + ip->i_flags |= XFS_NEED_INACTIVE; > + ip->i_flags &= ~XFS_INACTIVATING; > + spin_unlock(&ip->i_flags_lock); This doesn't look right. Shouldn't the first spin_unlock() be spin_lock()? Also, there's a typo in the comment (s/an/and). Best Andre -- Max Planck Institute for Biology Tel: (+49) 7071 601 829 Max-Planck-Ring 5, 72076 Tübingen, Germany http://people.tuebingen.mpg.de/maan/
Attachment:
signature.asc
Description: PGP signature
