> > -xfs_bmapi_convert_delalloc( > > +static int > > static inline? I'd just leave that to the compiler, no need to second guess all the decisions. > Double underscore prefixes read to me like "do this without grabbing > a lock or a resource", not just one step in a loop. > > Would you mind changing it to xfs_bmapi_convert_one_delalloc() ? > Then the callsite looks like: Fine with me.
