On Tue, Mar 19, 2024 at 02:32:48PM -0700, Christoph Hellwig wrote: > On Tue, Mar 19, 2024 at 10:34:13AM -0700, Darrick J. Wong wrote: > > On Tue, Mar 19, 2024 at 09:45:57AM +1100, Dave Chinner wrote: > > > From: Christoph Hellwig <hch@xxxxxx> > > > > > > With the concept of unmapped buffer gone, there is no reason to not > > > vmap the buffer pages directly in xfs_buf_alloc_folios. > > > > "..no reason to not map the buffer pages..."? > > or maybe > > "..no good reason to not map the buffer pages..." We might as well fix the split infinitive as well: "...no good reason not to map the buffer pages..." --D