On Thu, Mar 14, 2024 at 09:56:40PM +0000, Matthew Wilcox wrote: > This is userspace. I have no idea what I'm doing. Heh. > diff --git a/db/init.c b/db/init.c > index b108a06cfe..42757e44c6 100644 > --- a/db/init.c > +++ b/db/init.c > @@ -39,7 +39,6 @@ int force; > struct xfs_mount xmount; > struct xfs_mount *mp; > struct xlog xlog; > -libxfs_init_t x; I did rework the libxfs_init structure (and remove this typedef) in xfsprogs for-next, which I think should have also fixed the duplicated declaration for "x". The other fixups look ok to me. The global variables in libraries aren't exactly a nice pattern, but I think we'll have to live with them for now.
