Re: [PATCH 3/3] xfs_repair: rebuild block mappings from rmapbt data

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 13, 2024 at 06:59:54PM -0700, Christoph Hellwig wrote:
> > +#define min_t(type, x, y) ( ((type)(x)) > ((type)(y)) ? ((type)(y)) : ((type)(x)) )
> 
> Should this really be a hidden in a .c file in repair vs in a common
> header where we can use it everywhere?

Eh, yeah, I'll move it to libfrog/util.h.  I'll even use the one that's
in libxfs_priv.h.

#define min_t(type,x,y) \
	({ type __x = (x); type __y = (y); __x < __y ? __x: __y; })

--D

> Otherwise looks good:
> 
> Reviewed-by: Christoph Hellwig <hch@xxxxxx>
> 




[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux