Re: [PATCH] misc: fix test that fail formatting with 64k blocksize

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Mar 13, 2024 at 11:16:29PM +0800, Zorro Lang wrote:
> On Tue, Feb 27, 2024 at 06:39:45PM +0100, Pankaj Raghav (Samsung) wrote:
> > From: "Darrick J. Wong" <djwong@xxxxxxxxxx>
> > 
> > There's a bunch of tests that fail the formatting step when the test run
> > is configured to use XFS with a 64k blocksize.  This happens because XFS
> > doesn't really support that combination due to minimum log size
> > constraints. Fix the test to format larger devices in that case.
> > 
> > Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx>
> > Co-developed-by: Pankaj Raghav <p.raghav@xxxxxxxxxxx>
> > Signed-off-by: Pankaj Raghav <p.raghav@xxxxxxxxxxx>
> > ---
> 
> This change looks good to me, and it really fixes some testing failures.
> 
> Reviewed-by: Zorro Lang <zlang@xxxxxxxxxx>

Thanks.
> 
> BTW, I tested 64k blocksize xfs with this patch, there're still some failed
> test cases. If you're still interested in it, I'd like to list some of them
> as below (diff *.out *.out.bad output).
> 

I have some more test fixes but it is happening only when we have LBS,
i.e, 64k bs on a 4k system.

But I had a fix for xfs/558 [1]. Can you see if it fixes it?

[1] https://lore.kernel.org/linux-xfs/20240122111751.449762-2-kernel@xxxxxxxxxxxxxxxx/
> 
> *xfs/558 failed as:*
> 
> --- /dev/fd/63	2024-03-12 19:13:26.569223817 -0400
> +++ xfs/558.out.bad	2024-03-12 19:13:26.489224254 -0400
> @@ -1,2 +1,3 @@
>  QA output created by 558
> +Expected to hear about writeback iomap invalidations?
>  Silence is golden




[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux