On 2024/3/13 0:27, Darrick J. Wong wrote:
> On Tue, Mar 12, 2024 at 05:24:00AM -0700, Christoph Hellwig wrote:
>> On Mon, Mar 11, 2024 at 09:07:39AM -0700, Darrick J. Wong wrote:
>>> If at some point iomap_write_end actually starts returning partial write
>>> completions (e.g. you wrote 250 bytes, but for some reason the pagecache
>>> only acknowledges 100 bytes were written) then this code no longer
>>> reverts the iter or truncates posteof pagecache correctly...
>>
>> I don't think it makes sense to return a partial write from
>> iomap_write_end. But to make that clear it really should not return
>> a byte count by a boolean. I've been wanting to make that cleanup
>> for a while, but it would reach all the way into buffer.c.
>
> For now, can we change the return types of iomap_write_end_inline and
> __iomap_write_end? Then iomap can WARN_ON if the block_write_end return
> value isn't 0 or copied:
>
> bool ret;
>
> if (srcmap->type == IOMAP_INLINE) {
> ret = iomap_write_end_inline(iter, folio, pos, copied);
> } else if (srcmap->flags & IOMAP_F_BUFFER_HEAD) {
> size_t bh_written;
>
> bh_written = block_write_end(NULL, iter->inode->i_mapping,
> pos, len, copied, &folio->page, NULL);
>
> WARN_ON(bh_written != copied && bh_written != 0);
> ret = bh_written == copied;
> } else {
> ret = __iomap_write_end(iter->inode, pos, len, copied, folio);
> }
>
> ...
>
> return ret;
>
> Some day later we can circle back to bufferheads, or maybe they'll die
> before we get to it. ;)
>
It looks great to me for now, we can revise iomap first.
Thanks,
Yi.
