On Fri, Mar 01, 2024 at 09:47:56AM -0800, Darrick J. Wong wrote: > Might want to leave a comment here about why xfs uses $loop_dev unlike > the other clauses that use $img_file Well, as I tried to explain in my commit message running it against the file always seemed weird. The loop device is the canonical place to run fs tools against. I can throw in a cleanup patch to also do this for the other file systems.