On Thu, Feb 29, 2024 at 09:16:32AM -0800, Darrick J. Wong wrote: > We don't want to salvage in that case. I forgot to finish that last > paragraph: > > "If salvage recovers more bytes than i_disk_size then we have no idea if > di_size was broken or not because the target isn't null-terminated. In > theory the kernel will never do this (because it zeroes the xfs_buf > contents in xfs_trans_buf_get) but fuzzers could do that. Set the > target to DUMMY_TARGET in this case." > > and maybe add: > > "The symlink target will be preserved if scrub does not find any errors > in the symlink file, the number of bytes recovered matches i_disk_size, > and there are no nulls in the recovered target. In all other cases it > is set to DUMMY_TARGET." Sounds good.
