Re: [PATCH 4/4] xfs: ask the dentry cache if it knows the parent of a directory

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Feb 28, 2024 at 09:20:57AM -0800, Christoph Hellwig wrote:
> > +	parent = dget_parent(dentry);
> > +	if (!parent)
> > +		goto out_dput;
> > +
> > +	if (parent->d_sb != sc->ip->i_mount->m_super) {
> > +		dput(parent);
> > +		goto out_dput;
> > +	}
> 
> ->d_parent can't point to outside the current sb.

I know, I was being paranoid.  Granted if the dcache is broken then
there are probably bigger issues going on. :)

I'll change it to an ASSERT.

--D




[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux