On Tue, Feb 27, 2024 at 07:51:27AM -0800, Christoph Hellwig wrote: > > +static inline bool xfs_inode_has_bigallocunit(struct xfs_inode *ip) > > +{ > > + return XFS_IS_REALTIME_INODE(ip) && ip->i_mount->m_sb.sb_rextsize > 1; > > +} > > Given that bigallocunit is an entirely new term in XFS, maybe add > a big fat comment explaining it? > > Otherwise this looks useful. How about: /* * Decide if the file data allocation unit for this file is larger than * a single filesystem block. */ --D