On Fri, Feb 23, 2024 at 05:49:16PM +0100, Christoph Hellwig wrote: > On Fri, Feb 23, 2024 at 08:46:55AM -0800, Darrick J. Wong wrote: > > > The only "sane" way out would be to always use a deferred item, which we > > > should be doing for anything using new RT features, but we can't really > > > do that for legacy file systems without forcing a log incompat flag. > > > So while I don't particularly like the transaction flag it seems like > > > the least evil solution. > > > > I had thought about doing that for rtgroups=1 filesystems. :) > > I actually have a patch doing that in my "not quite finished" queue. > Given that your patch queue already enables it for rmap and reflink > it's pretty trivial. <nod> In that case I'm fine with this: Reviewed-by: Darrick J. Wong <djwong@xxxxxxxxxx> Some day we can deprecate !rtgroups filesystems and this will go away. Assuming one of us doesn't figure out a better way to do this. :P --D
