On 2024-02-22 21:31:56, Eric Biggers wrote: > On Mon, Feb 12, 2024 at 05:58:06PM +0100, Andrey Albershteyn wrote: > > fs-verity previously had debug printk but it was removed. This patch > > adds trace points to the same places where printk were used (with a > > few additional ones). > > Are all of these actually useful? There's a maintenance cost to adding all of > these. > Well, they were useful for me while testing/working on this patchset. Especially combining -e xfs -e fsverity was quite good for checking correctness and debugging with xfstests tests. They're probably could be handy if something breaks. Or you mean if each of them is useful? The ones which I added to signature verification probably aren't as useful as other; my intention adding them was to also cover these code paths. -- - Andrey
