On Mon, Feb 12, 2024 at 05:58:03PM +0100, Andrey Albershteyn wrote: > XFS will need to know log_blocksize to remove the tree in case of an tree_blocksize > diff --git a/include/linux/fsverity.h b/include/linux/fsverity.h > index 1eb7eae580be..ab7b0772899b 100644 > --- a/include/linux/fsverity.h > +++ b/include/linux/fsverity.h > @@ -51,6 +51,7 @@ struct fsverity_operations { > * @desc: the verity descriptor to write, or NULL on failure > * @desc_size: size of verity descriptor, or 0 on failure > * @merkle_tree_size: total bytes the Merkle tree took up > + * @tree_blocksize: size of the Merkle tree block There may be many Merkle tree blocks, so it doesn't really make sense to write "the Merkle tree block". Maybe write "the Merkle tree block size". Likewise in fs/btrfs/verity.c. - Eric