On Tue, Feb 20, 2024 at 10:30:03AM +1100, Dave Chinner wrote: > On Mon, Feb 19, 2024 at 07:34:47AM +0100, Christoph Hellwig wrote: > > To prepare for re-enabling delalloc on RT devices, track the data blocks > > (which use the RT device when the inode sits on it) and the indirect > > blocks (which don't) separately to xfs_mod_delalloc, and add a new > > percpu counter to also track the RT delalloc blocks. > > > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > ..... > > > @@ -4938,7 +4938,7 @@ xfs_bmap_del_extent_delay( > > fdblocks += del->br_blockcount; > > > > xfs_add_fdblocks(mp, fdblocks); > > - xfs_mod_delalloc(mp, -(int64_t)fdblocks); > > + xfs_mod_delalloc(ip, -(long)del->br_blockcount, -da_diff); > > return error; > > That change of cast type looks wrong. Yes, this should be a int64_t.
