On Tue, Feb 20, 2024 at 10:55:59AM +1100, Dave Chinner wrote: > I'd also like to see the rest of the rt-only code in __xfs_bunmapi() > lifted out of the function into a helper. It's a big chunk of code > inside the loop, and the code structure is: Yes, this code has been bothering me forever, and I've started at least three attempts at cleaning it up and for now given them up due to the really compliated exit conditions. I think it really should be done eventually, but I don't plan to add it to this series. It will probably end up changing some of the existing loop logic as some of that is pretty questionable and predates the nice iext iterators.