John Garry <john.g.garry@xxxxxxxxxx> writes: > This series expands atomic write support to filesystems, specifically > XFS. Since XFS rtvol supports extent alignment already, support will > initially be added there. When XFS forcealign feature is merged, then we > can similarly support atomic writes for a non-rtvol filesystem. > > Flag FS_XFLAG_ATOMICWRITES is added as an enabling flag for atomic writes. > > For XFS rtvol, support can be enabled through xfs_io command: > $xfs_io -c "chattr +W" filename > $xfs_io -c "lsattr -v" filename > [realtime, atomic-writes] filename Hi John, I first took your block atomic write patch series [1] and then applied this series on top. I also compiled xfsprogs with chattr atomic write support from [2]. [1]: https://lore.kernel.org/linux-nvme/20240124113841.31824-1-john.g.garry@xxxxxxxxxx/T/#m4ad28b480a8e12eb51467e17208d98ca50041ff2 [2]: https://github.com/johnpgarry/xfsprogs-dev/commits/atomicwrites/ But while setting +W attr, I see an Invalid argument error. Is there anything I need to do first? root@ubuntu:~# /root/xt/xfsprogs-dev/io/xfs_io -c "chattr +W" /mnt1/test/f1 xfs_io: cannot set flags on /mnt1/test/f1: Invalid argument root@ubuntu:~# /root/xt/xfsprogs-dev/io/xfs_io -c "lsattr -v" /mnt1/test/f1 [realtime] /mnt1/test/f1 > > The FS needs to be formatted with a specific extent alignment size, like: > mkf.xfs -r rtdev=/dev/sdb,extsize=16K -d rtinherit=1 /dev/sda > > This enables 16K atomic write support. There are no checks whether the > underlying HW actually supports that for enabling atomic writes with > xfs_io, though, so statx needs to be issued for a file to know atomic > write limits. > Here you say that xfs_io does not check whether underlying HW actually supports atomic writes or not. So I am assuming xfs_io -c "chattr +W" should have just worked? Sorry, I am still in the process of going over the patches, but I thought let me anyways ask this first. -ritesh
