Re: xfs_clear_incompat_log_features considered harmful?

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Feb 05, 2024 at 09:23:29PM -0800, Darrick J. Wong wrote:
> > 
> > Well, even with the current code base in Darrick's queue a mount alone
> > won't upgrade features, you need to do an explicit exchrange or online
> > repair operation.  And I think we should basically never do log or
> > other format incompatible changes without an explicit user action.
> 
> Should I add a flags bit to the ioctls so that programs can force them
> on if the process has CAP_SYS_ADMIN?

Please not, that's just a horrible interface.

> Or would you rather a mount option
> "-o allow_log_upgrades=1" so that's totally under control of whoever
> writes fstab?
>
> The first option probably turns into an "and now everyone sets this"
> thing; the second one clutters up the mount options.

Yes, that or a CAP_SYS_ADMIN ioctl on the fs.





[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux