Hi all, Here's the usual odd fixes for fstests. Most of these are cleanups and bug fixes for the recently merged xfs metadump v2 testing code. This second attempt fixes a severe bug in the cleanup code from the refactored metadump testing code and adds a few adjustments that the maintainer asked for. If you're going to start using this code, I strongly recommend pulling from my git trees, which are linked below. This has been running on the djcloud for months with no problems. Enjoy! Comments and questions are, as always, welcome. --D fstests git tree: https://git.kernel.org/cgit/linux/kernel/git/djwong/xfstests-dev.git/log/?h=random-fixes-2024.01.14 --- Commits in this patchset: * generic/256: constrain runtime with TIME_FACTOR * common/xfs: simplify maximum metadump format detection * common/populate: always metadump full metadata blocks * xfs/336: fix omitted -a and -o in metadump call * common: refactor metadump v1 and v2 tests, version 2 * xfs/{129,234,253,605}: disable metadump v1 testing with external devices * xfs/503: test metadump obfuscation, not progressbars * xfs/503: split copy and metadump into two tests * common/xfs: only pass -l in _xfs_mdrestore for v2 metadumps * xfs/122: fix for xfs_attr_shortform removal in 6.8 --- common/metadump | 152 +++++++++++++++++++++++++++++++++++++++++++++++++++++ common/populate | 2 - common/rc | 10 --- common/xfs | 49 ++++++++++++++++- tests/generic/256 | 7 ++ tests/xfs/122.out | 2 + tests/xfs/129 | 91 ++------------------------------ tests/xfs/234 | 92 ++------------------------------ tests/xfs/253 | 90 ++----------------------------- tests/xfs/284 | 4 + tests/xfs/291 | 32 ++++------- tests/xfs/336 | 2 - tests/xfs/432 | 31 ++--------- tests/xfs/503 | 82 ++++------------------------- tests/xfs/503.out | 6 +- tests/xfs/601 | 54 +++++++++++++++++++ tests/xfs/601.out | 4 + tests/xfs/605 | 92 +------------------------------- 18 files changed, 318 insertions(+), 484 deletions(-) create mode 100644 common/metadump create mode 100755 tests/xfs/601 create mode 100755 tests/xfs/601.out