On Thu, Feb 01, 2024 at 10:23:03PM -0800, Christoph Hellwig wrote: > Looks good: > > Reviewed-by: Christoph Hellwig <hch@xxxxxx> > > (still no huge fan of all the explicit callout of persons comments here > and in the previous patch) I'll reword those: "A reviewer was confused by the init_sa logic in this function. Upon checking the logic, I discovered that the code is imprecise. What we want to do here is check that there is an ownership record in the rmap btree for the AG that contains a btree block." and "A previous version of this patch also converted the open-coded flags logic to helpers. This was removed due to the pending refactoring (that follows this patch) to eliminate most of the state flags." Thanks for the reviews, btw! --D
