Hi all, Minor cleanups for the btree block pointer checking code. If you're going to start using this code, I strongly recommend pulling from my git trees, which are linked below. This has been running on the djcloud for months with no problems. Enjoy! Comments and questions are, as always, welcome. --D kernel git tree: https://git.kernel.org/cgit/linux/kernel/git/djwong/xfs-linux.git/log/?h=btree-check-cleanups xfsprogs git tree: https://git.kernel.org/cgit/linux/kernel/git/djwong/xfsprogs-dev.git/log/?h=btree-check-cleanups --- Commits in this patchset: * xfs: simplify xfs_btree_check_sblock_siblings * xfs: simplify xfs_btree_check_lblock_siblings * xfs: open code xfs_btree_check_lptr in xfs_bmap_btree_to_extents * xfs: consolidate btree ptr checking * xfs: misc cleanups for __xfs_btree_check_sblock * xfs: remove the crc variable in __xfs_btree_check_lblock * xfs: tighten up validation of root block in inode forks * xfs: consolidate btree block verification * xfs: rename btree helpers that depends on the block number representation * xfs: factor out a __xfs_btree_check_lblock_hdr helper --- fs/xfs/libxfs/xfs_alloc_btree.c | 8 + fs/xfs/libxfs/xfs_bmap.c | 2 fs/xfs/libxfs/xfs_bmap_btree.c | 8 + fs/xfs/libxfs/xfs_btree.c | 252 +++++++++++++++++------------------- fs/xfs/libxfs/xfs_btree.h | 44 ++---- fs/xfs/libxfs/xfs_ialloc_btree.c | 8 + fs/xfs/libxfs/xfs_refcount_btree.c | 8 + fs/xfs/libxfs/xfs_rmap_btree.c | 8 + fs/xfs/scrub/btree.c | 21 +-- 9 files changed, 159 insertions(+), 200 deletions(-)