On Wed, Jan 24, 2024 at 10:40:33AM +0100, Andrey Albershteyn wrote: > In XFS_DAS_NODE_REMOVE_ATTR case, xfs_attr_mode_remove_attr() sets > filter to XFS_ATTR_INCOMPLETE. The filter is then reset in > xfs_attr_complete_op() if XFS_DA_OP_REPLACE operation is performed. > > The filter is not reset though if XFS just removes the attribute > (args->value == NULL) with xfs_attr_defer_remove(). attr code goes > to XFS_DAS_DONE state. > > Fix this by always resetting XFS_ATTR_INCOMPLETE filter. The replace > operation already resets this filter in anyway and others are > completed at this step hence don't need it. > > Signed-off-by: Andrey Albershteyn <aalbersh@xxxxxxxxxx> Shuld this have a Fixes: tag? Otherwise looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx>
