On Wed, Jan 17, 2024 at 06:33:07PM +0100, Christoph Hellwig wrote: > Hi all, > > this series cleans up the libxfs toplogy code and then fixes detection > of the log sector size in mkfs.xfs, so that it doesn't create smaller > than possible log sectors by default on > 512 byte sector size devices. > > Note that this doesn't cleanup the types of the topology members, as > that creeps all the way into platform_findsize. Which has a lot more > cruft that should be dealth with and is worth it's own series. > > Changes since v1: > - fix a spelling mistake > - add a few more cleanups Series looks good to me. Nice cleanup! Reviewed-by: Dave Chinner <dchinner@xxxxxxxxxx> -- Dave Chinner david@xxxxxxxxxxxxx