Looks good: Reviewed-by: Christoph Hellwig <hch@xxxxxx> > > +/* > + * WARNING: do not initialise any parameters in this function that depend on > + * mount option parsing having already been performed as this can be called from > + * fsopen() before any parameters have been set. > + */ > static int xfs_init_fs_context( ... while you're at it, can you switch this to the normal XFS format: static int xfs_init_fs_context(