On Mon, Jan 08, 2024 at 05:23:46PM -0800, Darrick J. Wong wrote: > > > > +#ifdef CONFIG_XFS_QUOTA > > > > +void xchk_qcheck_set_corrupt(struct xfs_scrub *sc, unsigned int dqtype, > > > > + xfs_dqid_t id); > > > > +#endif /* CONFIG_XFS_QUOTA */ > > > > > > No need for the ifdef here. > > > > Fixed. > > ...and reverted because I forgot to remove the #ifdef around the > tracepoint in that function. I tried to fix that, and got a ton of > macro spew over ... something not being defined. In the end, I decided > that it was better not to waste memory on !CONFIG_XFS_QUOTA and not to > waste time on minor things like this. Note that I only meant the ifdef on the declaration in the header, not for the function itself anyway, sorry.
