Hello Darrick J. Wong,
The patch 04f0c3269b41: "xfs: check rt summary file geometry more
thoroughly" from Dec 15, 2023 (linux-next), leads to the following
Smatch static checker warning:
fs/xfs/scrub/rtsummary.c:288 xchk_rtsum_compare()
warn: missing error code? 'error'
fs/xfs/scrub/rtsummary.c
268 for (off = 0; off < endoff; off++) {
269 union xfs_suminfo_raw *ondisk_info;
270
271 /* Read a block's worth of ondisk rtsummary file. */
272 error = xfs_rtsummary_read_buf(&rts->args, off);
273 if (!xchk_fblock_process_error(sc, XFS_DATA_FORK, off, &error))
274 return error;
275
276 /* Read a block's worth of computed rtsummary file. */
277 error = xfsum_copyout(sc, sumoff, rts->words, mp->m_blockwsize);
278 if (error) {
279 xfs_rtbuf_cache_relse(&rts->args);
280 return error;
281 }
282
283 ondisk_info = xfs_rsumblock_infoptr(&rts->args, 0);
284 if (memcmp(ondisk_info, rts->words,
285 mp->m_blockwsize << XFS_WORDLOG) != 0) {
286 xchk_fblock_set_corrupt(sc, XFS_DATA_FORK, off);
287 xfs_rtbuf_cache_relse(&rts->args);
--> 288 return error;
^^^^^^^^^^^^^
This is zero. Should be some kind of error code.
289 }
290
291 xfs_rtbuf_cache_relse(&rts->args);
292 sumoff += mp->m_blockwsize;
293 }
294
295 return 0;
296 }
regards,
dan carpenter
