On Wed, Jan 03, 2024 at 05:14:00PM -0800, Darrick J. Wong wrote: > > @@ -1875,25 +1874,18 @@ xfs_btree_check_block_owner( > > struct xfs_btree_cur *cur, > > struct xfs_btree_block *block) > > { > > - if (!xfs_has_crc(cur->bc_mp)) > > + if (!xfs_has_crc(cur->bc_mp) || > > I wonder, shouldn't this be (bc_flags & XFS_BTREE_CRC_BLOCKS) and not > xfs_has_crc? They're one and the same, but as the geometry flags are > all getting moved to xfs_btree_ops, we ought to be consistent about what > we check. Sure.