On Wed, Jan 03, 2024 at 04:20:24PM -0800, Darrick J. Wong wrote: > On Wed, Jan 03, 2024 at 08:41:25AM +0000, Christoph Hellwig wrote: > > Rewrite xfile_obj_store to use xfile_get_page and xfile_put_page to > > access the data in the shmem page cache instead of abusing the > > shmem write_begin and write_end aops. > > > > Signed-off-by: Christoph Hellwig <hch@xxxxxx> > > Much simpler, though I wonder if willy is going to have something to say > about xfile.c continuing to pass pages around instead of folios. I > /think/ that's ok since we actually need the physical base page for > doing IO, right? Well, as mentioned in the cover letter I'd much prefer to return a folio here, but we'd first need to sort out the whole hwpoison flag mess for that first. There's also a few issues with the xfs-internal xfiles interface that need attention, but they're solvable.
