On Tue, Jan 02, 2024 at 05:07:47PM -0800, Darrick J. Wong wrote: > The main arches that xfs really cares about are arm64, ppc64, riscv, > s390x, and x86_64, right? Perhaps there's a stronger case for only > providing blocking notifiers and jump labels since there aren't many > m68k xfs users, right? Yes. And if there are m68k xfs users, they are even more unlikely to run with online repair enabled as they'd be very memory constrained. So I suspect always using blocking notifiers would be best to keep the complexity down. In fact I suspect we should simply make online repair depend on jump labels instead of selecting it when available to remove anoher rarely tested build combination.