On Tue, Jan 2, 2024 at 8:23 PM Darrick J. Wong <djwong@xxxxxxxxxx> wrote: > > From: Darrick J. Wong <djwong@xxxxxxxxxx> > > cron jobs don't belong in /usr/lib. Since the cron job is also > secondary to the systemd timer, it's really only provided as a courtesy > for distributions that don't use systemd. Move it to @datadir@, aka > /usr/share/xfsprogs. > > Signed-off-by: Darrick J. Wong <djwong@xxxxxxxxxx> > --- > include/builddefs.in | 1 - > scrub/Makefile | 2 +- > 2 files changed, 1 insertion(+), 2 deletions(-) > > > diff --git a/include/builddefs.in b/include/builddefs.in > index 9d0f9c3bf7c..f5138b5098f 100644 > --- a/include/builddefs.in > +++ b/include/builddefs.in > @@ -51,7 +51,6 @@ PKG_SBIN_DIR = @sbindir@ > PKG_ROOT_SBIN_DIR = @root_sbindir@ > PKG_ROOT_LIB_DIR= @root_libdir@@libdirsuffix@ > PKG_LIB_DIR = @libdir@@libdirsuffix@ > -PKG_LIB_SCRIPT_DIR = @libdir@ > PKG_LIBEXEC_DIR = @libexecdir@/@pkg_name@ > PKG_INC_DIR = @includedir@/xfs > DK_INC_DIR = @includedir@/disk > diff --git a/scrub/Makefile b/scrub/Makefile > index 8fb366c922c..472df48a720 100644 > --- a/scrub/Makefile > +++ b/scrub/Makefile > @@ -26,7 +26,7 @@ INSTALL_SCRUB += install-crond > CRONTABS = xfs_scrub_all.cron > OPTIONAL_TARGETS += $(CRONTABS) > # Don't enable the crontab by default for now > -CROND_DIR = $(PKG_LIB_SCRIPT_DIR)/$(PKG_NAME) > +CROND_DIR = $(PKG_DATA_DIR) > endif > > endif # scrub_prereqs > > Looks good to me. Reviewed-by: Neal Gompa <neal@xxxxxxxxx> -- 真実はいつも一つ！/ Always, there's only one truth!
