Hi all, The refcountbt repair code has serious memory usage problems when the block sharing factor of the filesystem is very high. This can happen if a deduplication tool has been run against the filesystem, or if the fs stores reflinked VM images that have been aging for a long time. Recall that the original reference counting algorithm walks the reverse mapping records of the filesystem to generate reference counts. For any given block in the AG, the rmap bag structure contains the all rmap records that cover that block; the refcount is the size of that bag. For online repair, the bag doesn't need the owner, offset, or state flag information, so it discards those. This halves the record size, but the bag structure still stores one excerpted record for each reverse mapping. If the sharing count is high, this will use a LOT of memory storing redundant records. In the extreme case, 100k mappings to the same piece of space will consume 100k*16 bytes = 1.6M of memory. For offline repair, the bag stores the owner values so that we know which inodes need to be marked as being reflink inodes. If a deduplication tool has been run and there are many blocks within a file pointing to the same physical space, this will stll use a lot of memory to store redundant records. The solution to this problem is to deduplicate the bag records when possible by adding a reference count to the bag record, and changing the bag add function to detect an existing record to bump the refcount. In the above example, the 100k mappings will now use 24 bytes of memory. These lookups can be done efficiently with a btree, so we create a new refcount bag btree type (inside of online repair). This is why we refactored the btree code in the previous patchset. The btree conversion also dramatically reduces the runtime of the refcount generation algorithm, because the code to delete all bag records that end at a given agblock now only has to delete one record instead of (using the example above) 100k records. As an added benefit, record deletion now gives back the unused xfile space, which it did not do previously. If you're going to start using this code, I strongly recommend pulling from my git trees, which are linked below. This has been running on the djcloud for months with no problems. Enjoy! Comments and questions are, as always, welcome. --D kernel git tree: https://git.kernel.org/cgit/linux/kernel/git/djwong/xfs-linux.git/log/?h=repair-refcount-scalability xfsprogs git tree: https://git.kernel.org/cgit/linux/kernel/git/djwong/xfsprogs-dev.git/log/?h=repair-refcount-scalability --- libxfs/libxfs_api_defs.h | 8 + libxfs/xfs_alloc_btree.c | 2 libxfs/xfs_bmap_btree.c | 1 libxfs/xfs_btree.c | 24 --- libxfs/xfs_btree.h | 4 libxfs/xfs_ialloc_btree.c | 2 libxfs/xfs_refcount_btree.c | 1 libxfs/xfs_rmap_btree.c | 2 libxfs/xfs_types.h | 6 - repair/Makefile | 4 repair/rcbag.c | 396 +++++++++++++++++++++++++++++++++++++++++++ repair/rcbag.h | 33 ++++ repair/rcbag_btree.c | 394 +++++++++++++++++++++++++++++++++++++++++++ repair/rcbag_btree.h | 78 ++++++++ repair/rmap.c | 159 +++++------------ repair/slab.c | 130 -------------- repair/slab.h | 19 -- repair/xfs_repair.c | 6 + 18 files changed, 983 insertions(+), 286 deletions(-) create mode 100644 repair/rcbag.c create mode 100644 repair/rcbag.h create mode 100644 repair/rcbag_btree.c create mode 100644 repair/rcbag_btree.h
