Hi all, Online repair of the reverse-mapping btrees presens some unique challenges. To construct a new reverse mapping btree, we must scan the entire filesystem, but we cannot afford to quiesce the entire filesystem for the potentially lengthy scan. For rmap btrees, therefore, we relax our requirements of totally atomic repairs. Instead, repairs will scan all inodes, construct a new reverse mapping dataset, format a new btree, and commit it before anyone trips over the corruption. This is exactly the same strategy as was used in the quotacheck and nlink scanners. Unfortunately, the xfarray cannot perform key-based lookups and is therefore unsuitable for supporting live updates. Luckily, we already a data structure that maintains an indexed rmap recordset -- the existing rmap btree code! Hence we port the existing btree and buffer target code to be able to create a btree using the xfile we developed earlier. Live hooks keep the in-memory btree up to date for any resources that have already been scanned. This approach is not maximally memory efficient, but we can use the same rmap code that we do everywhere else, which provides improved stability without growing the code base even more. Note that in-memory btree blocks are always page sized. This patchset modifies the kernel xfs buffer cache to be capable of using a xfile (aka a shmem file) as a backing device. It then augments the btree code to support creating btree cursors with buffers that come from a buftarg other than the data device (namely an xfile-backed buftarg). For the userspace xfs buffer cache, we instead use a memfd or an O_TMPFILE file as a backing device. If you're going to start using this code, I strongly recommend pulling from my git trees, which are linked below. This has been running on the djcloud for months with no problems. Enjoy! Comments and questions are, as always, welcome. --D kernel git tree: https://git.kernel.org/cgit/linux/kernel/git/djwong/xfs-linux.git/log/?h=in-memory-btrees xfsprogs git tree: https://git.kernel.org/cgit/linux/kernel/git/djwong/xfsprogs-dev.git/log/?h=in-memory-btrees --- fs/xfs/Kconfig | 8 fs/xfs/Makefile | 2 fs/xfs/libxfs/xfs_ag.c | 6 fs/xfs/libxfs/xfs_ag.h | 4 fs/xfs/libxfs/xfs_btree.c | 173 ++++++- fs/xfs/libxfs/xfs_btree.h | 17 + fs/xfs/libxfs/xfs_btree_mem.h | 128 ++++++ fs/xfs/libxfs/xfs_refcount_btree.c | 4 fs/xfs/libxfs/xfs_rmap_btree.c | 4 fs/xfs/scrub/bitmap.c | 28 + fs/xfs/scrub/bitmap.h | 3 fs/xfs/scrub/scrub.c | 5 fs/xfs/scrub/scrub.h | 3 fs/xfs/scrub/trace.c | 11 fs/xfs/scrub/trace.h | 109 +++++ fs/xfs/scrub/xfbtree.c | 837 ++++++++++++++++++++++++++++++++++++ fs/xfs/scrub/xfbtree.h | 63 +++ fs/xfs/scrub/xfile.c | 181 ++++++++ fs/xfs/scrub/xfile.h | 66 +++ fs/xfs/xfs_aops.c | 5 fs/xfs/xfs_bmap_util.c | 8 fs/xfs/xfs_buf.c | 203 ++++++--- fs/xfs/xfs_buf.h | 79 +++ fs/xfs/xfs_buf_xfile.c | 97 ++++ fs/xfs/xfs_buf_xfile.h | 20 + fs/xfs/xfs_discard.c | 9 fs/xfs/xfs_file.c | 6 fs/xfs/xfs_health.c | 3 fs/xfs/xfs_ioctl.c | 3 fs/xfs/xfs_iomap.c | 4 fs/xfs/xfs_log.c | 4 fs/xfs/xfs_log_recover.c | 3 fs/xfs/xfs_mount.h | 3 fs/xfs/xfs_trace.c | 3 fs/xfs/xfs_trace.h | 85 +++- fs/xfs/xfs_trans.h | 1 fs/xfs/xfs_trans_buf.c | 42 ++ 37 files changed, 2105 insertions(+), 125 deletions(-) create mode 100644 fs/xfs/libxfs/xfs_btree_mem.h create mode 100644 fs/xfs/scrub/xfbtree.c create mode 100644 fs/xfs/scrub/xfbtree.h create mode 100644 fs/xfs/xfs_buf_xfile.c create mode 100644 fs/xfs/xfs_buf_xfile.h
