Re: [PATCH]: mkfs.xfs: correct the error prompt in usage()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Wed, Dec 20, 2023 at 09:59:04AM +0800, Wu Guanghao wrote:
> According to the man page description, su=value and sunit=value are both
> used to specify the unit for a RAID device/logical volume. And swidth and
> sw are both used to specify the stripe width.
> 
> So in the prompt we need to associate su with sunit and sw with swidth.
> 
> Signed-by-off: Wu Guanghao <wuguanghao3@xxxxxxxxxx>
> ---
>  mkfs/xfs_mkfs.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/mkfs/xfs_mkfs.c b/mkfs/xfs_mkfs.c
> index dd3360dc..c667b904 100644
> --- a/mkfs/xfs_mkfs.c
> +++ b/mkfs/xfs_mkfs.c
> @@ -993,7 +993,7 @@ usage( void )
>  /* metadata */         [-m crc=0|1,finobt=0|1,uuid=xxx,rmapbt=0|1,reflink=0|1,\n\
>                             inobtcount=0|1,bigtime=0|1]\n\
>  /* data subvol */      [-d agcount=n,agsize=n,file,name=xxx,size=num,\n\
> -                           (sunit=value,swidth=value|su=num,sw=num|noalign),\n\
> +                           (sunit=value|su=num,swidth=value|sw=num,noalign),\n\

Doesn't mkfs require sunit/swidth or su/sw to be used together, but not
intermixed?

--D

>                             sectsize=num\n\
>  /* force overwrite */  [-f]\n\
>  /* inode size */       [-i perblock=n|size=num,maxpct=n,attr=0|1|2,\n\
> --
> 2.27.0
> 




[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux