Re: [PATCH 22/22] xfs: rename xfs_bmap_rtalloc to xfs_rtallocate_extent

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 18, 2023 at 02:24:30PM -0800, Darrick J. Wong wrote:
> > -xfs_bmap_rtalloc(
> > +xfs_rtallocate_extent(
> >  	struct xfs_bmalloca	*ap)
> 
> Hmm.  I'm still not sure I like the name here -- we're doing an rt
> allocation for a bmap allocation args structure.
> 
> xfs_rtalloc_bmap?
> 
> (Or just drop this one, I've lost my will to fight over naming.)

I have to say I don't really like the bmap in the low-level allocator
to start with, but maybe for that to happen we need to stop passing
the xfs_bmalloca structure.

So droppign it and living the with the pre-existing name for now until
we can clean up the whole are further seems like a good plan to me.




[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux