On Mon, Dec 18, 2023 at 05:57:28AM +0100, Christoph Hellwig wrote:
> Doing a break in the else side of a conditional is rather silly. Invert
> the check, break ASAP and unindent the other leg.
>
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>
Reviewed-by: Darrick J. Wong <djwong@xxxxxxxxxx>
--D
> ---
> fs/xfs/xfs_rtalloc.c | 9 ++++-----
> 1 file changed, 4 insertions(+), 5 deletions(-)
>
> diff --git a/fs/xfs/xfs_rtalloc.c b/fs/xfs/xfs_rtalloc.c
> index fbc60658ef24bf..924665b66210ed 100644
> --- a/fs/xfs/xfs_rtalloc.c
> +++ b/fs/xfs/xfs_rtalloc.c
> @@ -283,12 +283,11 @@ xfs_rtallocate_extent_block(
> /*
> * If not done yet, find the start of the next free space.
> */
> - if (next < end) {
> - error = xfs_rtfind_forw(args, next, end, &i);
> - if (error)
> - return error;
> - } else
> + if (next >= end)
> break;
> + error = xfs_rtfind_forw(args, next, end, &i);
> + if (error)
> + return error;
> }
> /*
> * Searched the whole thing & didn't find a maxlen free extent.
> --
> 2.39.2
>
>
