Re: [PATCH 18/23] libxfs: mark libxfs_device_{open,close} static

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, Dec 11, 2023 at 05:37:37PM +0100, Christoph Hellwig wrote:
> libxfs_device_open and libxfs_device_close are only used in init.c.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Reviewed-by: Carlos Maiolino <cmaiolino@xxxxxxxxxx>

> ---
>  include/libxfs.h | 2 --
>  libxfs/init.c    | 4 ++--
>  2 files changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/include/libxfs.h b/include/libxfs.h
> index 9ee3dd979..68efe9caa 100644
> --- a/include/libxfs.h
> +++ b/include/libxfs.h
> @@ -148,8 +148,6 @@ int		libxfs_init(struct libxfs_init *);
>  void		libxfs_destroy(struct libxfs_init *li);
> 
>  extern int	libxfs_device_to_fd (dev_t);
> -extern dev_t	libxfs_device_open (char *, int, int, int);
> -extern void	libxfs_device_close (dev_t);
>  extern int	libxfs_device_alignment (void);
>  extern void	libxfs_report(FILE *);
> 
> diff --git a/libxfs/init.c b/libxfs/init.c
> index 87193c3a6..13ad7899c 100644
> --- a/libxfs/init.c
> +++ b/libxfs/init.c
> @@ -92,7 +92,7 @@ libxfs_device_to_fd(dev_t device)
>  /* libxfs_device_open:
>   *     open a device and return its device number
>   */
> -dev_t
> +static dev_t
>  libxfs_device_open(char *path, int creat, int xflags, int setblksize)
>  {
>  	dev_t		dev;
> @@ -161,7 +161,7 @@ retry:
>  	/* NOTREACHED */
>  }
> 
> -void
> +static void
>  libxfs_device_close(dev_t dev)
>  {
>  	int	d;
> --
> 2.39.2
> 




[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux