On Mon, Dec 18, 2023 at 08:12:12AM +1100, Dave Chinner wrote: > > +struct xfs_attr_sf_hdr { /* constant-structure header block */ > > + __be16 totsize; /* total bytes in shortform list */ > > + __u8 count; /* count of active entries */ > > + __u8 padding; > > +}; > > + > > +struct xfs_attr_sf_entry { > > + __u8 namelen; /* actual length of name (no NULL) */ > > + __u8 valuelen; /* actual length of value (no NULL) */ > > + __u8 flags; /* flags bits (see xfs_attr_leaf.h) */ > > May as well correct the comment while you are touching this > structure; xfs_attr_leaf.h has not existed for a long time. Perhaps > just "/* XFS_ATTR_* flags */" as they are defined a little further > down this same file... Yeah, I'll update it for the next version.