Re: [PATCH 02/19] xfs: turn the xfs_trans_mod_dquot_byino stub into an inline function

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Thu, Dec 14, 2023 at 07:34:21AM +0100, Christoph Hellwig wrote:
> Without this upcoming change can cause an unused variable warning,
> when adding a local variable for the fields field passed to it.
> 
> Signed-off-by: Christoph Hellwig <hch@xxxxxx>

Stupid warnings...
Reviewed-by: Darrick J. Wong <djwong@xxxxxxxxxx>

--D

> ---
>  fs/xfs/xfs_quota.h | 5 ++++-
>  1 file changed, 4 insertions(+), 1 deletion(-)
> 
> diff --git a/fs/xfs/xfs_quota.h b/fs/xfs/xfs_quota.h
> index dcc785fdd34532..e0d56489f3b287 100644
> --- a/fs/xfs/xfs_quota.h
> +++ b/fs/xfs/xfs_quota.h
> @@ -127,7 +127,10 @@ xfs_qm_vop_dqalloc(struct xfs_inode *ip, kuid_t kuid, kgid_t kgid,
>  }
>  #define xfs_trans_dup_dqinfo(tp, tp2)
>  #define xfs_trans_free_dqinfo(tp)
> -#define xfs_trans_mod_dquot_byino(tp, ip, fields, delta) do { } while (0)
> +static inline void xfs_trans_mod_dquot_byino(struct xfs_trans *tp,
> +		struct xfs_inode *ip, uint field, int64_t delta)
> +{
> +}
>  #define xfs_trans_apply_dquot_deltas(tp)
>  #define xfs_trans_unreserve_and_mod_dquots(tp)
>  static inline int xfs_trans_reserve_quota_nblks(struct xfs_trans *tp,
> -- 
> 2.39.2
> 
> 




[Index of Archives]     [XFS Filesystem Development (older mail)]     [Linux Filesystem Development]     [Linux Audio Users]     [Yosemite Trails]     [Linux Kernel]     [Linux RAID]     [Linux SCSI]


  Powered by Linux