On Fri, Dec 08, 2023 at 04:57:37PM -0800, Luis Chamberlain wrote: > On Mon, Nov 06, 2023 at 05:26:14PM +1100, Dave Chinner wrote: > > > XFS: Assertion failed: ip->i_nblocks == 0, file: fs/xfs/xfs_inode.c, line: 2359 > > > > IOWs, all four of these issues are the same problem - journal > > recovery is not resulting in a correct and consistent filesystem > > after the journal has been flushed at runtime, so please discuss and > > consolidate them all in the initial bug report thread.... > > As recently reported, fortunately we now have reproducers for x86_64 too: > > https://bugzilla.kernel.org/show_bug.cgi?id=218224 > > This fails on the following test sections as defined by kdevops [1]: > > * xfs_nocrc_2k > * xfs_reflink > * xfs_reflink_1024 > * xfs_reflink_2k > * xfs_reflink_4k > * xfs_reflink_dir_bsize_8k > * xfs_reflink_logdev > * xfs_reflink_normapbt > * xfs_reflink_nrext64 > > [0] https://github.com/linux-kdevops/kdevops/blob/master/playbooks/roles/fstests/templates/xfs/xfs.config > > Example failures: > > * generic/475: https://gist.github.com/mcgrof/5d6f504f4695ba27cea7df5d63f35197 > * generic/388: https://gist.github.com/mcgrof/c1c8b1dc76fdc1032a5f0aab6c2a14bf > * generic/648: https://gist.github.com/mcgrof/1e506ecbe898b45428d6e7febfc02db1 If this is the same problem, have you tested whether the fix for the s390 issue makes all the problems you are seeing on x86-64 go away? i.e. commit 7930d9e10370 ("xfs: recovery should not clear di_flushiter unconditionally") -Dave. -- Dave Chinner david@xxxxxxxxxxxxx
